[gstreamer-bugs] [Bug 435120] cairosvgoverlay

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Nov 8 00:11:50 PST 2010


https://bugzilla.gnome.org/show_bug.cgi?id=435120
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #169859|none                        |needs-work
             status|                            |

--- Comment #24 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-11-08 08:11:45 UTC ---
Review of attachment 169859:
 --> (https://bugzilla.gnome.org/review?bug=435120&attachment=169859)

Looks good to me. I'd rather get this in, than having it bitrotting here.

::: ext/rsvg/gstrsvgoverlay.c
@@ +19,3 @@
+
+/**
+ * SECTION:element-rsvg_overlay

this should be "SECTION:element-rsvgoverlay"

@@ +212,3 @@
+
+  gst_adapter_push (overlay->adapter, buffer);
+  /* FIXME: some code samples do 

GST_PAD_PARENT does not ref, gst_pad_parent() refs. In the chain function, you
can avoid the ref. So just remove the FIXME: comment. And let us know of the
broken "code samples" if you remember.

@@ +356,3 @@
+      g_param_spec_string ("data", "data", "RSVG data.", "",
+          G_PARAM_WRITABLE | G_PARAM_STATIC_STRINGS));
+  g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_FILENAME,

I think we usually call this "location".

@@ +368,3 @@
+      g_param_spec_int ("y", "y offset",
+          "Specify a y offset", 0, G_MAXINT, 0, G_PARAM_READWRITE));
+

please add "| G_PARAM_STATIC_STRINGS" to the last three properties.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list