[gstreamer-bugs] [Bug 613827] Queue is not waiting to fill buffer until it's reaches to min-threshold-buffers value

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Nov 10 09:54:05 PST 2010


https://bugzilla.gnome.org/show_bug.cgi?id=613827
  GStreamer | gstreamer (core) | unspecified

--- Comment #5 from Venkat <vinjam5678 at gmail.com> 2010-11-10 17:54:02 UTC ---
(In reply to comment #4 Current implementation of queue is ineffective with
min-threshold-buffers parameter. This parameter is very helpful to reduce CPU
wake ups at various levels i.e. user, kernel driver and platform level. I am
requesting you to change the following line of code.

This is a bug in the code. no one see this unless they use full features of
queue with max-size-buffers and min-threshold-buffers parameters.

The changes needed in gstqueue.c at gstreamer/plugins/elements/
function:gst_queue_chain (GstPad * pad, GstBuffer * buffer)

        /* don't leak. Instead, wait for space to be available */
        do {
          /* for as long as the queue is filled, ait until
min-threshold-buffers reaches. */
          GST_QUEUE_WAIT_DEL_CHECK (queue, out_flushing);
        } while (!gst_queue_is_empty(queue)); /*bug in the code*/

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list