[gstreamer-bugs] [Bug 626618] jpegparse doesn't handle APP12 marker

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626618
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174664|none                        |reviewed
             status|                            |

--- Comment #42 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-11-19 14:48:58 UTC ---
Review of attachment 174664:
 --> (https://bugzilla.gnome.org/review?bug=626618&attachment=174664)

Not a big deal, but keeping the detail in the log might help actually
implementing those app-markers in the future.

::: gst/jpegformat/gstjpegparse.c
@@ -643,3 @@
-            marker, id_str, size - 2);
-        break;
-      }

The point of this code was that we know that it contains a "id_str" and we can
log that to have more info about what is in the file. That is lost with the
generic gst_jpeg_parse_skip_marker().

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.