[gstreamer-bugs] [Bug 626618] jpegparse doesn't handle APP12 marker

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Nov 19 09:10:35 PST 2010


https://bugzilla.gnome.org/show_bug.cgi?id=626618
  GStreamer | gst-plugins-bad | git

--- Comment #48 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> 2010-11-19 17:10:33 UTC ---
(In reply to comment #42)
> Review of attachment 174664 [details]:
> 
> Not a big deal, but keeping the detail in the log might help actually
> implementing those app-markers in the future.
> 
> ::: gst/jpegformat/gstjpegparse.c
> @@ -643,3 @@
> -            marker, id_str, size - 2);
> -        break;
> -      }
> 
> The point of this code was that we know that it contains a "id_str" and we can
> log that to have more info about what is in the file. That is lost with the
> generic gst_jpeg_parse_skip_marker().

Yeah, but IMO just logging the first string in the block doesn't help a lot. I
think is preferable wait for further implementation of the APP?? extraction.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list