[gstreamer-bugs] [Bug 626618] jpegparse doesn't handle APP12 marker
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Nov 19 09:16:25 PST 2010
https://bugzilla.gnome.org/show_bug.cgi?id=626618
GStreamer | gst-plugins-bad | git
--- Comment #50 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> 2010-11-19 17:16:22 UTC ---
(In reply to comment #45)
> Review of attachment 174666 [details]:
>
> Looks good in general. To be sure, you only refactored the app1 code out of the
> switch and also extracted the post_metadata code. There are no other changes?
No other changes in this regard.
>
> ::: gst/jpegformat/gstjpegparse.c
> @@ +519,3 @@
> +static inline void
> +post_metadata (GstJpegParse * parse, guint size, guint8 * data,
> + GstTagList * (*TagFunc) (const GstBuffer * buff))
>
> tiny nitpick, we would name "TagFunc" -> "tag_func"
> also what about naming this function "extract_and_post_tags"
Sure. I can do that.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the Gstreamer-bugs
mailing list