[gstreamer-bugs] [Bug 617318] matroskademux, qtdemux: Use pbutils for H.264 profile/level extraction

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=617318
  GStreamer | gst-plugins-good | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162338|none                        |committed
             status|                            |

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-10-01 16:13:28 UTC ---
(From update of attachment 162338)
Pushed this, with one commit per element (mostly because it didn't apply as it
was and it was easier to apply individually).

I added calls to gst_pb_utils_init() to the plugin init function (doesn't do
much at the moment, but should be there).

Also fixed up what I presume were off-by-one errors (size parameter should be
-1):

>+      /* First byte is the version, second is the profile indication, and third
>+       * is the 5 contraint_set_flags and 3 reserved bits. Fourth byte is the
>+       * level indication. */
>+      gst_codec_utils_h264_caps_set_profile (caps, data + 1, size);
>+      gst_codec_utils_h264_caps_set_level (caps, data + 1, size);
> 
>       memcpy (GST_BUFFER_DATA (priv), data, size);
>       gst_caps_set_simple (caps, "codec_data", GST_TYPE_BUFFER, priv, NULL);


>+                /* First 4 bytes are the length of the atom, the next 4 bytes
>+                 * are the fourcc, the next 1 byte is the version, and the
>+                 * subsequent bytes are sequence parameter set like data. */
>+                gst_codec_utils_h264_caps_set_profile (stream->caps,
>+                    avc_data + 0x9, size);
>+                gst_codec_utils_h264_caps_set_level (stream->caps,
>+                    avc_data + 0x9, size);
> 
>                 GST_DEBUG_OBJECT (qtdemux, "found avcC codec_data in stsd");

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.