[gstreamer-bugs] [Bug 631200] flacparse: major performance improvements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=631200
  GStreamer | gst-plugins-bad | git

--- Comment #16 from Felipe Contreras <felipe.contreras at gmail.com> 2010-10-03 11:59:45 UTC ---
(In reply to comment #15)
> Well, let's not argue about that here (and FWIW I'm successfully using git-bz).

Yes, some project's bugzillas are easier to setup than others. But just the
though of re-basing my patches in case I need configurations not supported
scares me away.

> From a short look at your patches you're still parsing the complete FLAC
> frames. Didn't you say yesterday on IRC that you're only looking for a) a sync
> marker and b) that a valid frame header follows and then simply push everything
> until the next valid sync marker/frame header downstream?

Yes:
(In reply to comment #7)
> Created an attachment (id=171600)
 View: https://bugzilla.gnome.org/attachment.cgi?id=171600
 Review: https://bugzilla.gnome.org/review?bug=631200&attachment=171600

> rewrite sync matching

See:
 * get_next_sync -> frame_header_is_valid

> And what's the reason for dropping the optional CRC16 frame check (which
> defaults to FALSE)? I added it some time ago and planned to post a message on
> the bus for broken frames to provide a tool for checking FLAC files for
> corruptions.

I was porting the parsing code and I didn't want to port that, I don't find it
useful anyway. As I said, I wasn't intending to post the patches.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.