[gstreamer-bugs] [Bug 631200] flacparse: major performance improvements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=631200
  GStreamer | gst-plugins-bad | git

--- Comment #33 from Felipe Contreras <felipe.contreras at gmail.com> 2010-10-23 01:43:06 UTC ---
(In reply to comment #31)
> (From update of attachment 171603 [details])
> I don't see anything wrong with this code either.
> 
> a) Every list node always contains a valid buffer reference

Not true, there are some error conditions where this doesn't happen.

I know because I saw the warnings of gst_mini_object_unref(), which why I
bothered writing the patch.

BTW. gst_mini_object_unref has a silly API, should be:
void gst_mini_object_unref(void *mini_object);

And should accept NULL, that would make it really useful, similar to free(),
and g_object_unref().

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.