[gstreamer-bugs] [Bug 632682] [matroskademux] Handle missing CodecPrivate for Vorbis/Theora

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=632682
  GStreamer | gst-plugins-good | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-bugs at lists.source
                   |                            |forge.net
   Target Milestone|HEAD                        |0.10.26

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-10-23 15:16:38 UTC ---
If we return a GST_FLOW_ERROR, we should post a proper error message on the
bus. I've changed the patch to do that.

(I guess ideally we'd just mark that track as broken and skip it and continue
playing other non-broken tracks if there are any, but I guess it's not really
worth it seeing that this is just plain broken, and we're just trying to
prevent crashes though hand-crafted files.)

commit 7fcd7d8cf29c22ff1bbcd1969fa353306a4d49e7
Author: Philip Jägenstedt <philipj at opera.com>
Date:   Wed Oct 20 10:21:48 2010 +0200

    matroskademux: Remove useless clearing of send_xiph_headers for Dirac

    This looks like a mistake when copy-pasting the Theora code.

    https://bugzilla.gnome.org/show_bug.cgi?id=632682

commit 6cf398cdf30a65481ec160165048c4396cff76f7
Author: Philip Jägenstedt <philipj at opera.com>
Date:   Wed Oct 20 13:28:28 2010 +0200

    matroskademux: don't crash if vorbis/theora codec data is missing

    Error out properly in this case instead of crashing.

    https://bugzilla.gnome.org/show_bug.cgi?id=632682

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.