[gstreamer-bugs] [Bug 632885] Gaudi Effects dynamically controllable parameters [review]

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=632885
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173012|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2010-10-23 19:22:09 UTC ---
Review of attachment 173012:
 --> (https://bugzilla.gnome.org/review?bug=632885&attachment=173012)

Looks good in general... any reason why you only make some properties
controllable... and only some elements?

you should also call gst_controller_init() in gstplugin.c

::: gst/gaudieffects/gstchromium.h
@@ -72,3 @@
   GstVideoFilter videofilter;
-
-  /* < private > */

You should keep this comment, otherwise gtk-doc will show it

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.