[gstreamer-bugs] [Bug 632778] Optimisations to GstBaseSink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=632778
  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172912|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2010-10-23 19:39:47 UTC ---
Review of attachment 172912:
 --> (https://bugzilla.gnome.org/review?bug=632778&attachment=172912)

::: libs/gst/base/gstbasesink.c
@@ +2221,3 @@
+      obj_type = _PR_IS_EVENT;
+    else if (GST_IS_BUFFER_LIST (obj))
+      obj_type = _PR_IS_BUFFERLIST;

Maybe add a "else g_return_if_reached()" here

@@ +3120,3 @@
+    ret =
+        gst_base_sink_render_object (basesink, pad,
+        GST_IS_BUFFER (o) ? _PR_IS_BUFFER : _PR_IS_EVENT, o);

This could be a bufferlist too here, right?

@@ +3163,3 @@
  * This function takes ownership of obj.
+ *
+ * Note: Only GstEvent seem to be passed to this private method

Maybe add an assertion for this here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.