[gstreamer-bugs] [Bug 586570] Add GAP Flag support to audioresample

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=586570
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #169879|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge <slomo at circular-chaos.org> 2010-09-10 19:33:05 UTC ---
Review of attachment 169879:
 --> (https://bugzilla.gnome.org/review?bug=586570&attachment=169879)

Looks good in general

::: gst/audioresample/gstaudioresample.c
@@ +198,3 @@
+      g_param_spec_boolean ("gap-aware", "Gap Aware", "true = skip buffers " \
+          "flagged as gaps;  false = process all buffers", FALSE,
+          G_PARAM_READWRITE | G_PARAM_CONSTRUCT));

Please don't add a property for this. The gap-aware mode should be the default
and only mode. If it works correctly there's no reason to disable it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.