[gstreamer-bugs] [Bug 629553] New: GstAdapter: timestamp not updated when empty buffer is pushed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=629553
  GStreamer | gstreamer (core) | git

           Summary: GstAdapter: timestamp not updated when empty buffer is
                    pushed
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: lsinger at caltech.edu
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=170182)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=170182)
Proposed patch

gst_adapter_push() does not update the timestamp that gets returned by
gst_adapter_prev_timestamp() if the size of the buffer that is pushed is zero. 
If the adapter is empty, it should be OK to think of pushing a zero-size buffer
as updating the adapter's timestamp, and setting the distance to the end of the
queue to zero.

The attached patch adds code for this corner case to gst_adapter_push().  If
the buffer's size is zero, and the adapter does not contain any buffers, then
the adapter's timestamp is set to the buffer's timestamp, and the distance to
the end of the adapter is set to zero.

This patch should make more elements able to gracefully handle size zero
buffers.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.