[gstreamer-bugs] [Bug 630322] seek example doesn't compile in windows and is missing a couple of useful buttons

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=630322
  GStreamer | gst-plugins-base | git

--- Comment #5 from Vladimir <wl2776 at gmail.com> 2010-09-24 07:02:48 UTC ---
(In reply to comment #4)
> (In reply to comment #1)
> > Created an attachment (id=170816)
 View: https://bugzilla.gnome.org/attachment.cgi?id=170816
 Review: https://bugzilla.gnome.org/review?bug=630322&attachment=170816

[details] [review]
> > Compile in windows (at least in OSSBuild)
> 
> You should use DEFAULT_AUDIOSINK, DEFAULT_VIDEOSINK, etc instead of hardcoding
> some values depending on the platform.
They were already. I simply added a couple windows-related.

Since these defines are related to the configuration, which developer is free
to change according to his needs of testing, I think, these DEFAULTs should be
added along with existing ones.

> Also, please file another bug for the two other patches, better don't have
> patches doing completely unrelated things in the same bug.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.