[gstreamer-bugs] [Bug 616814] Photography interface extension

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=616814
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159683|none                        |needs-work
             status|                            |

--- Comment #10 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-09-24 09:41:39 UTC ---
Review of attachment 159683:
 --> (https://bugzilla.gnome.org/review?bug=616814&attachment=159683)

Hu, sorry I forgot about the patch. I can push it for next gst-plugin-bad
release though, if you could update it according to my comments.

::: gst-libs/gst/interfaces/photography.c
@@ +300,3 @@
+ *
+ * Returns: %TRUE if setting the value succeeded, %FALSE otherwise
+ */

Please add
 * Since: 0.10.21

@@ +309,3 @@
+ *
+ * Returns: %TRUE if getting the value succeeded, %FALSE otherwise
+ */

Please add
 * Since: 0.10.21

::: gst-libs/gst/interfaces/photography.h
@@ +92,3 @@
+ * of high-ISO capturing, some noise remains after YCC NR. XNR reduces this
+ * remaining noise.
+ */

Please add
 * Since: 0.10.21

::: gst/camerabin/gstcamerabin.c
@@ +3194,3 @@
+  g_object_class_override_property (gobject_class, ARG_NOISE_REDUCTION,
+      GST_PHOTOGRAPHY_PROP_NOISE_REDUCTION);
+

we don't proxy the photo iface anymore in camerabin. applications can get the
camera-src and make the changes there. Thus there is no
gstcamerabinphotography.c any more. Please remove this part of the patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.