[gstreamer-bugs] [Bug 617314] pbutils: Add codec-specific utility functions for AAC, H.264, MPEG-4 video

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=617314
  GStreamer | gst-plugins-base | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-bugs at lists.source
                   |                            |forge.net
   Target Milestone|HEAD                        |0.10.31
            Summary|pbutils: Add codec-specific |pbutils: Add codec-specific
                   |utility functions           |utility functions for AAC,
                   |                            |H.264, MPEG-4 video

--- Comment #18 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-09-30 14:15:24 UTC ---
Pushed most of these now. Sorry it took so long!

I combined the _caps_set_profile() and _caps_set_level() functions into one
single _caps_set_level_and_profile() function for each format, which is a bit
bulky, but seems to reflect the usage better (no point in having two separate
functions if both are always called together)

Also did a bunch of minor changes:

 - renamed gst_codec_utils_aac_get_sample_rate() to _rate_from_index()

 - added some g_return_val_if_fail() guards

 - moved some static vars around / mucked with const arrays a bit

 - dereference data only after the size check

 - required the "mpegversion" field to be set on the aac caps for
   _set_level_and_profile() instead of having it as an argument



commit 515a768dbc0b1b3ae1fc6265771b8bc8a776966a
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Thu Sep 30 00:19:29 2010 +0100

    docs: add new codec utils API to docs

commit def1cf727634698e31accbce259d565a20856673
Author: Arun Raghavan <arun.raghavan at collabora.co.uk>
Date:   Sat May 1 01:03:18 2010 +0530

    pbutils: Add MPEG-4 Video profile/level extraction

    This adds code to translate the profile_and_level indication from the
    MPEG-4 video (ISO/IEC 14496-2) headers to a string profile/level. The
    mappings are taken from the spec and Wireshark's code, and might need to
    be expanded on.

    https://bugzilla.gnome.org/show_bug.cgi?id=617314

    API: gst_codec_utils_mpeg4video_get_profile()
    API: gst_codec_utils_mpeg4video_get_level()
    API: gst_codec_utils_mpeg4video_caps_set_level_and_profile()

commit e4bd09f0ed3f33a202eac94149feb8452548f1ff
Author: Arun Raghavan <arun.raghavan at collabora.co.uk>
Date:   Fri Apr 30 20:50:09 2010 +0530

    pbutils: add H.264 profile/level extraction functions to codec utils

    This adds code to parse the first few bytes of H.264 sequence parameter
    set in order to extract the profile and level as const strings. This
    code was originally in both qtdemux and matroskademux.

    https://bugzilla.gnome.org/show_bug.cgi?id=617314

    API: gst_codec_utils_h264_get_level()
    API: gst_codec_utils_h264_get_profile()
    API: gst_codec_utils_h264_caps_set_level_and_profile()

commit 0cf81938a160a9c16dc4903766dbea76f166ffe5
Author: Arun Raghavan <arun.raghavan at collabora.co.uk>
Date:   Fri Apr 30 15:12:04 2010 +0530

    pbutils: add AAC profile detection to codec utils

    This moves AAC profile detection to pbutils, and uses this in
    typefindfunctions. This will also be used in qtdemux.

    https://bugzilla.gnome.org/show_bug.cgi?id=617314

    API: gst_codec_utils_aac_get_profile()
    API: codec_utils_aac_caps_set_level_and_profile()

commit c77f88cac675a1dbb89e40da8e3c28320523bfca
Author: Arun Raghavan <arun.raghavan at collabora.co.uk>
Date:   Fri Apr 30 13:41:17 2010 +0530

    pbutils: add codec-specific utility functions for AAC

    This allows us to add generic codec-specific functionality, like
    extracting profile/level data from headers, without having to duplicate
    code across demuxers and typefindfunctions.

    As a starting point, this moves over AAC level extraction code from
    typefindfunctions, so it can be reused in qtdemux, etc.

    https://bugzilla.gnome.org/show_bug.cgi?id=617314

    API: gst_codec_utils_aac_get_sample_rate_from_index()
    API: gst_codec_utils_aac_get_level()

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.