[Bug 646570] baseaudiosink: don't allow aligning behind the read-segment

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Apr 4 00:32:10 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=646570
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |slomo at circular-chaos.org
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.33

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2011-04-04 07:32:06 UTC ---
commit 588ac0ae6fdfb55c612cc84f5426cbf1ee4aec4e
Author: Havard Graff <havard.graff at tandberg.com>
Date:   Tue Feb 8 18:27:43 2011 +0100

    baseaudiosink: don't allow aligning behind the read-segment

    Given a large enough drift-tolerance, one could end up in a situation
    where one would keep aligning the written buffers behind the current
    read-segment position. The result for the reader would be complete
    silence, possible preceded by very choppy audio.

    By checking the available headroom, one can determine if there is
    room to do alignment, or if one should resort to a resync instead to get
    the pointers back on track.

    Also refactor the alignment-logic out of the render function for cleaner
    code.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list