[Bug 638749] (Duration) queries on a source-only bin are currently not supported

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Apr 8 05:03:07 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=638749
  GStreamer | gstreamer (core) | git

--- Comment #15 from Sebastian Dröge <slomo at circular-chaos.org> 2011-04-08 12:03:05 UTC ---
(In reply to comment #14)
> (In reply to comment #13)
> > * You're adding the query iterate stuff as public API. Not a good idea, please
> > put the header in noinst_HEADERS (or put the content in gstprivate.h)
> 
> Hum it's in noinst_HEADERS already :)

Sorry, you're right :)

> > * You should probably do the srcpad iteration only when necessary, i.e. for
> > duration queries so far
> 
> This contradicts your comment 8 or am I misunderstanding something?

Well, for non-duration queries you're currently iterating the srcpads but you
don't use the result. That's what I mean, if you don't use the result anyway
you can skip the iterating too.

In comment #8 I meant that you should do the srcpad iterations for other
queries too but of course you have to do something with the result then. And it
was about doing it in GstElement too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list