[Bug 647510] New: audiowsinclimit uses the wrong limits for the range of the kernel elements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=647510
  GStreamer | gst-plugins-good | git

           Summary: audiowsinclimit uses the wrong limits for the range of
                    the kernel elements
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: jordi.burguet.castell at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=185767)
 View: https://bugzilla.gnome.org/attachment.cgi?id=185767
 Review: https://bugzilla.gnome.org/review?bug=647510&attachment=185767

change len -> len-1  where appropiate in the high- and low-pass filters

Hi,

In audiowsinclimit.c the kernel elements and windows are written as if the
counter went from 0 to len, included. But they should go from 0 to len-1.

The confusion comes from using the reference
http://www.dspguide.com/ch16/2.htm
where the counter goes up to M = len-1.

The attached patch corrects this issue, and also handles better the case of a
filter with an even number of elements.

Jordi

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.