[Bug 645502] [h264parse] leaks fatally on certain streams

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=645502
  GStreamer | gst-plugins-bad | git

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |mnauw at users.sourceforge.net
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.22

--- Comment #4 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-04-12 12:29:57 UTC ---
Running valgrind on some filesrc ! mpegtsdemux ! h264parse ! fakesink variant,
I would say there never was "fatal" leaking, and that some small leaking has
been handled by following commits:

commit cfb22fe9858ba6ad776d57af034b8a2d278ed7be
Author: René Stadler <mail at renestadler.de>
Date:   Thu Mar 24 21:46:09 2011 +0200

    h264parse: free PPS NAL buffers on cleanup

    Obviously a typo. Fixes bug #645502.

commit 3e4e198c5ed26c58d703b28eb417410b85e35370
Author: René Stadler <mail at renestadler.de>
Date:   Thu Mar 24 21:44:07 2011 +0200

    h264parse: don't leak all NAL buffers

    gst_buffer_replace() doesn't steal the ref. Partial fix for bug #645502.

commit 82a152533db90a1207dce352df4592c291b07e0f
Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Tue Mar 22 13:18:03 2011 +0100

    h264parse: chain up to parent finalize

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.