[Bug 647830] New: assrender: crashes with very large subtitles

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=647830
  GStreamer | gst-plugins-bad | git

           Summary: assrender: crashes with very large subtitles
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: ds at schleef.org
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=185993)
 View: https://bugzilla.gnome.org/attachment.cgi?id=185993
 Review: https://bugzilla.gnome.org/review?bug=647830&attachment=185993

patch

assrender crashes writing outside the video image area if the subtitle image is
large enough, and the y position is odd.  Example crash video at
http://www.schleef.org/~ds/ghost-crab-bad-subtitles.mkv

The blit code seems to make the assumption that the y position is even.  That
is, if the x or y position is odd, it technically rendered wrong.  As a
workaround, I rounded down to even.  After the release, I can orcify the
blitting and fix it at the same time.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.