[Bug 647856] [oggmux] Assumes that the first buffer can be used to detect the stream type

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=647856
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #186020|none                        |accepted-commit_now
             status|                            |

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2011-04-15 13:29:26 UTC ---
Review of attachment 186020:
 --> (https://bugzilla.gnome.org/review?bug=647856&attachment=186020)

Looks good

::: ext/ogg/gstoggmux.c
@@ +864,3 @@
+                const GstBuffer *buf = gst_value_get_buffer (first_element);
+                if (buf) {
+                  ogg_packet packet;

you're shadowing the packet variable from the outer scope here. Might confuse
people but it's not a problem of course ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.