[Bug 647856] [oggmux] Assumes that the first buffer can be used to detect the stream type

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=647856
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-04-16 10:59:49 UTC ---
I've moved most of this code into a new
gst_ogg_stream_setup_map_from_caps_headers() function, which makes the logic
here clearer IMHO, and also sprinkled some more debug logging for miscellaneous
error/failure cases. Hope I didn't mess anything up in the process:

 commit 55e767b6328e6cc0db7bf6ac23cdf4e0eab537e6
 Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
 Date:   Fri Apr 15 13:36:39 2011 +0100

    oggmux: prefer headers from caps to determine stream type

    Ogg mandates the first header packet must determine a stream's type.
    However, some streams (such as VP8) do not include such a header
    when muxed in other containers, and thus do not include this header
    as a buffer, but only in caps. We thus use headers from caps when
    available to determine a new stream's type.

    https://bugzilla.gnome.org/show_bug.cgi?id=647856

Thanks for the patch!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.