[Bug 648312] New: [v4l2sink] Unconditionally accepts video/mpegts

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=648312
  GStreamer | gst-plugins-good | git

           Summary: [v4l2sink] Unconditionally accepts video/mpegts
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: bilboed at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


When v4l2sink is raised to a non-null rank (because system has a v4l2 output
device) and when playbin2 plays back a mpeg-ts file, it ends up auto-plugging
the mpeg-ts stream directly to v4l2sink.

This is because v4l2sink unconditionally accepts video/mpegts and doesn't check
whether the hardware can actually support it.

The culprit seems to be in gstv4l2object:
@@ -1842,6 +1863,9 @@ gst_v4l2_object_set_format (GstV4l2Object * v4l2object,
guint32 pixelformat,
   memset (&format, 0x00, sizeof (struct v4l2_format));
   format.type = v4l2object->type;

+  if (pixelformat == GST_MAKE_FOURCC ('M', 'P', 'E', 'G'))
+    return TRUE;
+
   if (v4l2_ioctl (fd, VIDIOC_G_FMT, &format) < 0)
     goto get_fmt_failed;

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.