[Bug 651615] ogg vorbis files transcoded by apps won't play in Android
bugzilla at gnome.org
Thu Aug 11 00:09:27 PDT 2011
GStreamer | gst-plugins-base | 0.10.34
--- Comment #9 from Sebastian Dröge <slomo at circular-chaos.org> 2011-08-11 07:09:22 UTC ---
Some thoughts about the patches
patch 193463: We use different tolerances everywhere unfortunately. Some
encoders use a multiple milliseconds value, some multiple or one sample, some
don't allow any tolerance at all, some allow one "frame" of difference. In
general your patch is correct though, especially the part with the negative
difference. We should reach some consensus here before pushing this though,
something like MAX(N milliseconds, M samples) probably makes most sense for
some values of N and M ;)
patch 193464: This one is correct too but could you check in the convert_src
and convert_sink functions if any of the other conversions should use correct
rounding too? From a short look I'd say all of them should be changed.
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs