[Bug 636562] SSE misalignment removal in "audioresample"
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Aug 11 00:17:06 PDT 2011
https://bugzilla.gnome.org/show_bug.cgi?id=636562
GStreamer | gst-plugins-base | 0.10.30
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #193559|none |needs-work
status| |
--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2011-08-11 07:17:01 UTC ---
Review of attachment 193559:
--> (https://bugzilla.gnome.org/review?bug=636562&attachment=193559)
::: gst/audioresample/resample.c
@@ +89,3 @@
#include "speex_resampler.h"
#include "arch.h"
+#if defined HAVE_CPU_I386 || defined HAVE_CPU_X86_64
You should also check for xmmintrin.h (SSE) emmintrin.h (SSE2) in configure and
only enable the SSE(2) code if they're available
@@ +90,3 @@
#include "arch.h"
+#if defined HAVE_CPU_I386 || defined HAVE_CPU_X86_64
+#include "sse.h"
Where do you get sse.h from?
@@ +949,3 @@
+#if defined HAVE_CPU_I386 || defined HAVE_CPU_X86_64
+ st->use_sse = sse_ok ();
You should make usage of SSE and SSE2 conditional based on the CPU capability
function in ORC. Note that there is SSE and SSE2 code in resample_sse.h and
ideally you want to compile in both and select the better one.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list