[Bug 639055] discoverer: add support for subtitle streams
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Aug 23 23:40:13 PDT 2011
https://bugzilla.gnome.org/show_bug.cgi?id=639055
GStreamer | gst-plugins-base | git
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #194493|none |reviewed
status| |
--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2011-08-24 06:40:07 UTC ---
Review of attachment 194493:
--> (https://bugzilla.gnome.org/review?bug=639055&attachment=194493)
Looks good but with the language code problem you mean that you don't get any
language at all for the subtitle streams, i.e. info->language is always NULL?
::: gst-libs/gst/pbutils/gstdiscoverer-types.c
@@ +256,3 @@
+{
+ if (info->language)
+ g_free (info->language);
g_free() is NULL-safe
::: gst-libs/gst/pbutils/gstdiscoverer.c
@@ +447,3 @@
"subpicture/x-pgs; subpicture/x-dvb; application/x-subtitle-unknown; "
"application/x-ssa; application/x-ass; subtitle/x-kate; "
+ "application/x-kate; video/x-dvd-subpicture; ");
Ideally you would make this a separate commit
@@ +831,3 @@
g_str_has_prefix (name1, "image/")) &&
+ g_str_has_prefix (name2, "video/x-raw")) ||
+ (g_str_has_suffix (name1, "/x-kate"))) {
Why?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list