[Bug 665294] [0.11] gstvalue: add stepped ranges

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=665294
  GStreamer | gstreamer (core) | unspecified

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #6 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-12-02 14:19:00 UTC ---
> This does not work, you have to explicitly specify the number of collect values
> when registering the type (the ii at the bottom should be an iii). You always
> need 3 arguments now and all code has to be change :(

Ah, I see.
Well, I moved it to 3, but went back to two arguments because:
- it would require changing a lot of client code, also in code I don't even
know exists
- it turns out there's precious little that has a use for non 1 steps anyway

> @@ +2982,3 @@
>    gint min;
>    gint max;
> +  gint step;
> 
> Wouldn't it be faster to first can_intersect() here?

AFAICT, can_intersect will just return TRUE if the types are compatible.
Which we already know they are.

> @@ +3403,2 @@
> +  if (step1 != step2) {
> +    /* ENOIMPL */
> 
> EPLEASEIMPL ;)

AFAICT, this case was only used for subset determination (A-B and B-A).
I've replaced this with an actual subset function (which ought to be faster
here, even), so this should not be needed. Especially if we then make this
private as you suggested.

Rest fixed/changed, plus a bit more tests, and other bugfixes.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.