[Bug 665412] matroskamux: jpeg muxing regression

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Dec 3 10:23:20 PST 2011


https://bugzilla.gnome.org/show_bug.cgi?id=665412
  GStreamer | gst-plugins-good | git

--- Comment #3 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-12-03 18:22:58 UTC ---
Created an attachment (id=202717)
 View: https://bugzilla.gnome.org/attachment.cgi?id=202717
 Review: https://bugzilla.gnome.org/review?bug=665412&attachment=202717

matroskaparse: do not write incorrect files when tags are seen early

Seeing tags was triggering the header flush, but since tags can be
written before other header type information, this would cause that
other information to not be written to the file.

This fixes parsing and rewriting of streamable files created by
matroskamux, but seems incomplete, as other information (such as
attachments) seem similar enough to warrant the same behavior.
However, I don't know the constraints for Matroska about the order
in which all the bits of information must be (1), so I'm doing the
least invasive patch for now, since it fixes the issue of not being
able to parse our own files.

(1) http://matroska.org/technical/diagram/index.html seems to put
almost everything in the same "segment" bin, implying there is no
ordering among those - unless there is strict ordering within the
bin, in which case matroskamux is wrong...

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list