[Bug 665529] New: GstPad push_sticky returns wrong value

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=665529
  GStreamer | gstreamer (core) | 0.11.x

           Summary: GstPad push_sticky returns wrong value
    Classification: Platform
           Product: GStreamer
           Version: 0.11.x
        OS/Version: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: matej.knopp at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=202738)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=202738)
patch

static gboolean
push_sticky (GstPad * pad, PadEvent * ev, gpointer user_data)
{
 ....
  return *data != GST_FLOW_OK;
}

the last line should be data == GST_FLOW_OK, otherwise it returns false when
sending the event succeeds, preventing subsequent sticky event to be sent
(events_foreach breaks if !ret)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.