[Bug 665078] opus: work without the Ogg headers

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=665078
  GStreamer | gst-plugins-bad | unspecified

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202962|none                        |reviewed
             status|                            |

--- Comment #12 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-12-07 11:49:33 UTC ---
Review of attachment 202962:
 --> (https://bugzilla.gnome.org/review?bug=665078&attachment=202962)

::: ext/opus/gstopusenc.c
@@ +446,3 @@
       enc->channel_mapping_family = 0;
+      enc->channel_mapping[0] = 0;
+      enc->channel_mapping[0] = 1;

The mapping is not used for family 0 (particularity of the format).

@@ +551,3 @@
+      n_stereo_streams = 0;
+  } else {
+    n_streams = enc->n_channels;

That's just hardcoding for RTP.
It should be done for all cases when working out the channel positions.
At the moment I set it to all mono till I understand this bit, but just special
casing the easy case means the general one is likely to get left undone...

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.