[Bug 665921] filesrc: Incorrect EOF detection in create_read
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Dec 12 05:29:38 PST 2011
https://bugzilla.gnome.org/show_bug.cgi?id=665921
GStreamer | gstreamer (core) | 0.10.35
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #203247|none |needs-work
status| |
--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2011-12-12 13:29:36 UTC ---
Review of attachment 203247:
--> (https://bugzilla.gnome.org/review?bug=665921&attachment=203247)
Looks good but:
::: plugins/elements/gstfilesrc.c
@@ +828,3 @@
+ length, offset + woffset);
+ ret = read (src->fd, GST_BUFFER_DATA (buf) + woffset, length);
+ if (G_UNLIKELY (ret < 0 && ret != -EAGAIN && ret != -EINTR))
read() returns -1 on error and you have to check errno for EAGAIN and EINTR
(not -EAGAIN and -EINTR)
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list