[Bug 662775] dv1394src: Add support for old kernels
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Dec 12 06:37:57 PST 2011
https://bugzilla.gnome.org/show_bug.cgi?id=662775
GStreamer | gst-plugins-good | git
Vincent Penquerc'h <vincent.penquerch> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vincent.penquerch at collabora
| |.co.uk
--- Comment #9 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-12-12 14:37:51 UTC ---
> The real operation that needs to be done here is bswap_32(), which is not
> portable.
It might be alright, I don't know what the hardware returns in detail, it just
seems odd and thus worth pointing out in case it was an oversight.
> @@ +186,3 @@
> clock->cycle_timer_hi = 0;
> +
> + if (raw1394_read_cycle_timer (clock->handle, &cycle_timer, &local_time) !=
> 0) {
>
> I might be wrong but from the docs, this functions returns an int:
> http://www.dennedy.org/libraw1394/API-raw1394-read-cycle-timer.html
Right, I mixed up raw1394_read_cycle_timer and gst_raw1394_read_cycle_timer,
named very similarly but returning different types.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list