[Bug 666174] [ffdec] segfault because gst_pad_alloc_buffer_and_set_caps return a buffer with a size of 0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=666174
  GStreamer | gst-ffmpeg | git

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mnauw at users.sourceforge.net

--- Comment #4 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-12-14 14:18:47 UTC ---
(In reply to comment #2)
> I see, this (and probably the a52dec crash) isn't simply fixed by using
> gst_pad_use_fixed_caps() on the srcpad because capsfilter will still allocate
> the first buffer itself now after one of the capsfilter changes recently.

While this may still be in 0.10 API specifications, capsfilter persistently
coming up with a size 0 buffer could surprise and crash a whole lot of (fixed
src pad caps) elements out there (that usually do not check for the size of the
returned buffer).  In particular, it might be wondered if the checks in core
could not be tightened instead (and provide fallback allocation) since no
element could do anything useful with a size 0 buffer (and certainly not fixed
caps ones which are not interested in caps either).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.