[Bug 610338] [0.11] [controller] Triggers should be moved into their own control source

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Dec 15 09:46:02 PST 2011


https://bugzilla.gnome.org/show_bug.cgi?id=610338
  GStreamer | gstreamer (core) | git

--- Comment #3 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-12-15 17:45:56 UTC ---
do we want to keep these in 0.11?
    GList *gst_interpolation_control_source_get_all
(GstInterpolationControlSource * self)
    gboolean gst_interpolation_control_source_set_from_list
(GstInterpolationControlSource *self, const GSList * timedvalues)

- the application most probably maintains a collection of the control points
for editing purposes anyway
- this collections is unlikely going to be a GSList of GstTimedValue
- in the optimistic case it contains GstTimedValues and the app needs to create
a GSList and throw it away afterwards
- then we can also loop outself and call gst_interpolation_control_source_set()
- this would help us to hide GstTimedValue from the api in 0.11

I am working on a GstTriggerControlSource, but would basically need to copy:
gst_trigger_control_source_set
gst_trigger_control_source_set_from_list
gst_trigger_control_source_unset
gst_trigger_control_source_unset_all
gst_trigger_control_source_get_all
gst_trigger_control_source_get_count

Another option would be to have a GstTimedValueControlSource abstract base
class as a root for GstTriggerControlSource and GstInterpolationControlSource.
Not sure if modifying the class hierarchy is an ABI break though?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list