[Bug 666352] 2bit DVB sub-pictures wrongly displayed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=666352
  GStreamer | gst-plugins-bad | 0.10.35

--- Comment #5 from Mart Raudsepp <leio at gentoo.org> 2011-12-21 11:12:50 UTC ---
Created an attachment (id=204027)
 View: https://bugzilla.gnome.org/attachment.cgi?id=204027
 Review: https://bugzilla.gnome.org/review?bug=666352&attachment=204027

dvbsuboverlay: Handle non_modifying_colour_flag correctly in the RLE handlers

The check for when to not memset was checking on an undeterministic 'bits'
variable value,
which is only meant to be used inside the loop earlier when it is supposed to
check if
clut_index is 1 together with non_mod set, as per spec:

"non_modifying_colour_flag:  If set to '1' this indicates that the CLUT entry
value '1'
is a non modifying colour. When the non modifying colour is assigned to an
object pixel,
then the pixel of the underlying region background or object shall not be
modified. This
can be used to create "transparent holes" in objects."

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.