[Bug 652195] matroskademux: seeking in non-finalized matroska files does not work correctly

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Dec 21 06:43:25 PST 2011


https://bugzilla.gnome.org/show_bug.cgi?id=652195
  GStreamer | gst-plugins-good | git

--- Comment #6 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-12-21 14:43:21 UTC ---
Created an attachment (id=204040)
 View: https://bugzilla.gnome.org/attachment.cgi?id=204040
 Review: https://bugzilla.gnome.org/review?bug=652195&attachment=204040

matroskademux: do not consider duration of non-finalized file

While it is slightly painful saying so given the effort that has been put into
the previous patches, it seems those patches introduce a whole lot of code and
complexity for a play/seek-file-being-created (corner) case

More importantly, however, I believe the present patch also supports this
corner case in a much easier and clearer way, namely simply invalidate the
(currently determined) duration in the segment (to avoid it messing with
requested seek position).  This is also not really a hack, since the duration
being invalidated is not really that valid/informative anyway (and only
temporary).

Likewise, the duration being determined (by lots of code seeking/scanning to
the end) is only "marginal" in that it will be outdated the moment it is
determined (as the file is still growing in this case).  In particular, e.g.
truncating a requested segment.stop position to an updated (but already
outdated) duration would not be quite right either, since the file could still
grow that position.  And moreover, performing a seek near the end will have the
duration updated anyway (when streaming resumes at that point).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list