[Bug 666545] [playbin2] Number of samples read from MP3/AAC files is less than expected

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=666545
  GStreamer | gst-plugins | 0.10.30

--- Comment #6 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-12-22 15:30:24 UTC ---
And it a bug in mad, or in the format - not quite sure and I did not really
look deeper than
http://www.mars.org/mailman/public/mad-dev/2001-May/000262.html.
Stuffing extra zero bytes after the last buffer "fixes" the missing samples.

So part of the bug is fixed, and apparently a bug in faad, so please file a bug
with faad for the AAC part. Not sure what to set the bug status to here.

commit 30e29b6fdbbcd28fc8d70e1146abd54ef0065aa3
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Thu Dec 22 15:23:54 2011 +0000

    mad: helpfully bodge the last buffer to let mad decode the last frame

    If http://www.mars.org/mailman/public/mad-dev/2001-May/000262.html is
    to be believed, the last buffer must be followed by a number of 0 bytes
    in order for the last frame to be decoded (at least in some cases).
    Doing so seems to work here, fixing a missing 1152 samples when using
    mp3parse before mad (not using mp3parse would yield the correct amount
    of samples, if there's extra non-MP3 data after (eg, tag data)).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.