[gstreamer-bugs] [Bug 641047] [mpegaudioparse] Multiple issues with new mpegaudioparse element from -bad, lower rank?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=641047
  GStreamer | gst-plugins-bad | unspecified

--- Comment #11 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-02-07 13:43:15 UTC ---
(In reply to comment #9)
> (From update of attachment 179891 [details])
> >@@ -1333,6 +1322,13 @@ gst_tag_demux_src_getrange (GstPad * srcpad,
> > {
> >   GstTagDemux *demux = GST_TAG_DEMUX (GST_PAD_PARENT (srcpad));
> > 
> >+  /* downstream in pull mode won't miss a newsegment event,
> >+   * but it likely appreciates other (tag) events */
> >+  if (demux->priv->need_newseg) {
> >+    gst_tag_demux_send_pending_events (demux);
> >+    demux->priv->need_newseg = FALSE;
> >+  }
> 
> Patch looks good to me, only thing I'm wondering is whether we need to make
> sure here (when pushing pending events in getrange) that we're not accidentally
> pushing a newsegment event that may have been queued before in a different
> mode. I don't know if this could happen or not though..

Had similar concerns.  
I suppose we could add an if (event == tag) or if (event != newsegment).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.