[gstreamer-bugs] [Bug 641246] No checks for availabily of GNonLin at runtime

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=641246
  GStreamer | gst-editing-services | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #180288|none                        |needs-work
             status|                            |

--- Comment #7 from Edward Hervey <bilboed at gmail.com> 2011-02-08 11:04:24 UTC ---
Review of attachment 180288:
 --> (https://bugzilla.gnome.org/review?bug=641246&attachment=180288)

Apart from the useless "multi-element-check", looks good.

::: ges/ges.c
@@ +43,3 @@
+    "gnloperation"
+  };
+  for (i = 0; i < G_N_ELEMENTS (plugins); i++) {

No need to check for all elements. Just checking for gnlcomposition will
suffice.

::: ges/ges.h
@@ +64,3 @@
 G_BEGIN_DECLS

+gboolean ges_init (void);

Even though I don't like switching the API ... this shouldn't cause any
problems (since noone was checking the return value previously)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.