[Bug 642433] [playbin2] improve autoplugging by considering direct connectivity to the sink element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=642433
  GStreamer | gst-plugins-base | 0.10.33

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #180991|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2011-02-16 14:04:50 UTC ---
Review of attachment 180991:
 --> (https://bugzilla.gnome.org/review?bug=642433&attachment=180991)

Only reviewing the uridecodebin part for now, will look at the playbin2 part
later today. Looks good in general but see the comments below.
Also please put the uridecodebin part into a separate commit (and use "git
format-patch" to create patches)

::: gst/playback/gsturidecodebin.c
@@ +336,3 @@
+  GValueArray *result;
+
+  result = g_value_array_copy (factories);

Wouldn't it be possible to just return factories here instead of creating a
copy? The default handler of decodebin2 already creates a copy and this way
playbin2 will *always* create two copies of the factories array for no good
reason

@@ +533,3 @@
+   *
+   * Returns: A new sorted array of #GstElementFactory objects.
+   */

Please add a "Since: 0.10.33" marker here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.