[Bug 642504] [mingw/cygwin build] correctly export plugin description

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=642504
  GStreamer | gstreamer (core) | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
                 CC|                            |t.i.m at zen.co.uk

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-02-17 16:33:17 UTC ---
> GST_PLUGIN_LDFLAGS contains 
> -export-symbols-regex '^[_]*gst_plugin_desc$'
>
> However, on cygwin or a mingw32 (cross-compile) build, e.g.
> libgstcoreelements.exp contents is (or rather should be) as follows:
> gst_plugin_desc DATA
> 
> That is, with the above regular expression (terminating $) it ends up empty.
> In case of Cygwin, that seems to lead to falling back to exporting all
> non-static symbols, but on (at least some) mingw setups that leads to no
> exported symbols (at least not gst_plugin_desc), and so plugin .dll's are not
> recognized as such.

This looks like a bug elsewhere to me (libtool?). It's a regex for the
*symbols* to be exported. The 'DATA' bit isn't part of the symbol, is it?

The [_]* bit at the front looks unnecessary to me and is likely a copy'n'paste
mistake. The terminator seems correct to me.

I don't necessarily *mind* the patch - it's likely harmless, since no one will
use symbols like gst_plugin_descwhatever in code (and if they do, who cares if
that gets exported), but it still looks more like a bug to me.


> note in particular that e.g.
> GST_LIB_LDFLAGS="-export-symbols-regex ^_?\(gst_\|Gst\|GST_\).*"
> contains no such termination restriction).

Well, of course not, since we really want to export everything that starts with
gst or _gst and ends in whatever. Wheras for plugins we really just want to
export the symbol called 'gst_plugin_desc' and nothing else.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.