[Bug 642667] New: [playbin2] autoplug-factories code does not do what it claims to do

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Feb 18 05:20:56 PST 2011


https://bugzilla.gnome.org/show_bug.cgi?id=642667
  GStreamer | gst-plugins-base | git

           Summary: [playbin2] autoplug-factories code does not do what it
                    claims to do
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: slomo at circular-chaos.org
         QAContact: gstreamer-bugs at lists.freedesktop.org
                CC: wim.taymans at gmail.com
      GNOME target: ---
     GNOME version: ---


Hi,
the current autoplug-factories code in playbin2 claims:

/* Called when we must provide a list of factories to plug to @pad with @caps.
 * We first check if we have a sink that can handle the format and if we do, we
 * return NULL, to expose the pad. If we have no sink (or the sink does not
 * work), we return the list of elements that can connect. */

NULL is never returned but if there's a sink that supports the caps it will be
returned together with the decoder elements.

Returning the sinks here will only confuse decodebin2 (if it really tries to
autoplug a sink) and this should be changed. Returning NULL if a sink is found
that supports the format would be an idea but not a very good one, this will
stop autoplugging but it does not guarantee that playbin2 will actually use
this sink. Instead the autoplug-factories code should probably only consider
a/v decoders and the code in autoplug-continue already checks if the selected
sink supports the caps.

OTOH this will not help much if no sink was manually set and the autosinks are
used, but that's the same with the current code (or with the idea from the
comment quoted above).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list