[Bug 643087] pulsesink: deadlock in gst_pulseringbuffer_open_device

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=643087
  GStreamer | gst-plugins-good | git

--- Comment #14 from Philip Jägenstedt <philipj at opera.com> 2011-02-24 12:36:11 UTC ---
(In reply to comment #13)
> (In reply to comment #12)
> > @@ -451,6 +452,8 @@ gst_pulseringbuffer_open_device (GstRingBuffer * buf)
> >    else
> >      pbuf->context_name = g_strdup (psink->client_name);
> > 
> > +  /* is it really necessary to take this lock here rather than just
> > +     after the g_mutex_unlock (pa_shared_resource_mutex) below? */
> >    pa_threaded_mainloop_lock (mainloop);
> > 
> >    g_mutex_lock (pa_shared_resource_mutex);
> 
> I think it is because it might create a new pulse context with that mainloop if
> none exists already.

The documentation for pa_context_new pa_threaded_mainloop_get_api doesn't say
that a lock is needed, but I guess there's no harm.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.