[Bug 642759] faceoverlay plugin: displays an SVG image over a detected face on a video stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=642759
  GStreamer | gst-plugins-bad | unspecified

--- Comment #5 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-02-28 13:45:12 UTC ---
Irks splinter is broken, manual copy'n'paste of the comment below:

Looks good. A bunch of comments though:
Please also run the c-file through gst-indent (the coding style differs from
the other plugins right now).

gst/faceoverlay/gstfaceoverlay.c

201     
202    static gboolean
203    gst_faceoverlay_create_childs (Gstfaceoverlay *filter)

-> create_children :)


325    g_object_set(filter->svg_overlay, "y", svg_y, NULL);
326    g_object_set(filter->svg_overlay, "width", svg_width, NULL);
327    g_object_set(filter->svg_overlay, "height", svg_height, NULL);

use one g_object_set() call, its faster.


331    g_object_set(filter->svg_overlay, "location", NULL, NULL);
332    }
333     

I believe you will need to chainup to the GstBin::message_handler.


347    "Filter/Editor/Video",
348    "Overlays SVG graphics over a detected face in a video stream",
349    "Laura Lucas Alday <<lauralucas at gmail.com>>");

There is a double "<<".


gst/faceoverlay/gstfaceoverlay.h
63    typedef struct _Gstfaceoverlay Gstfaceoverlay;
64    typedef struct _GstfaceoverlayClass GstfaceoverlayClass;
65     

please use CamelCase "GstFaceOverlay" and "GstFaceOverlayClass"


66    struct _Gstfaceoverlay
67    {
68    GstBin faceoverlaybin;

by convention we would just call this "GstBin parent;"


80    float y;
81    float w;
82    float h;

nitpick, use gfloat instead of float


89     
90    GType gst_faceoverlay_get_type (void);
91     

according to the naming change above, this would become
"gst_face_overlay_get_type()"

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.