[gstreamer-bugs] [Bug 640071] gstpluginloader: do not leak the description string

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=640071
  GStreamer | gstreamer (core) | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178843|none                        |reviewed
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-01-20 17:45:30 UTC ---
(From update of attachment 178843)
>   plugin->basename = g_path_get_basename (plugin->filename);
>   plugin->desc.name = g_intern_string (plugin->basename);
>-  plugin->desc.description = g_strdup_printf ("Plugin for blacklisted file");
>+  plugin->desc.description = "Plugin for blacklisted file";
>   plugin->desc.version = g_intern_string ("0.0.0");
>   plugin->desc.license = g_intern_string ("BLACKLIST");
>   plugin->desc.source = plugin->desc.license;
>-- 

This should probably be interned as well, for clarity and consistency (though I
admit I can't really see why these string constants need to be interned at all
- if not, we should probably change the others as well then, or at least use
g_intern_static_string()).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.