[Bug 653601] audiodelay: new element in audiofx providing an audio delay line

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=653601
  GStreamer | gst-plugins-good | git

--- Comment #11 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-07-02 00:57:25 UTC ---
(In reply to comment #9)
> (In reply to comment #8)
> > So its the same as the existing audioecho effect with intensity=100% and
> > feedback=0%, but a lot more efficient.
> 
> I don't think this proposed element is the same.  It is supposed to output a
> delayed copy of the input.
> 
> When intensity=100% and feedback=0%, doesn't audioecho output the sum of the
> input and a delayed copy of itself?

Right, need to check how it works in audioecho. In the audiodelay element I
have in gst-buzztard I have a drywet control:

beats-per-minute    : the number of beats per minute the top level pipeline
uses
                      flags: readable, writable
                      Unsigned Long. Range: 1 - 18446744073709551615 Default:
120 Current: 120
drywet              : Intensity of effect (0 none -> 100 full)
                      flags: readable, writable, controllable
                      Unsigned Integer. Range: 0 - 100 Default: 50 Current: 50
delaytime           : Time difference between two echos as milliseconds
                      flags: readable, writable, controllable
                      Unsigned Integer. Range: 1 - 1000 Default: 100 Current:
100
feedback            : Echo feedback in percent
                      flags: readable, writable, controllable
                      Unsigned Integer. Range: 0 - 99 Default: 50 Current: 50



> 
> > Regarding your doc-blob change, please don't suggest the element to be used for
> > creating an echo effect. One can only achieve that by mixing the original
> > signal in and should just use audioecho then directly.
> 
> Fixed in new patch.
> 
> > I don't know what other think, but I would like this not to be classified as an
> > effect. Just imagine someone doing a gstreamer audio effect rack. If one plugs
> > this elements as an insert effect one would not really hear a differences
> > before and after.
> 
> Should I put this element in a standalone plugin of the same name?

Maybe, at least change the classification. "Filter/Effect/Audio" hints that it
is an effect. I would like to see what Thiago (bug 641024) and others think.
Having a generic way to delays streams sounds  nicer. 

I also checked and the audiofiter elements do handle the latency query. Maybe
the issue you have is that adder does not care about timestamps and latency. It
just mixes samples as they come.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.