[Bug 630292] x264enc: Use the new x264 API to request a keyframe

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=630292
  GStreamer | gst-plugins-ugly | unspecified

--- Comment #10 from Andoni Morales <ylatuya at gmail.com> 2011-07-08 10:11:39 UTC ---
Review of attachment 182888:
 --> (https://bugzilla.gnome.org/review?bug=630292&attachment=182888)

::: ext/x264/gstx264enc.c
@@ +1579,3 @@
+      x264_encoder_intra_refresh (encoder->x264enc);
+    else
+      pic_in.i_type = X264_TYPE_IDR;

pic_in.i_type is only set if FORCE_INTRA_API is definied but it should be set
even if it's not defined:
#else
  pic_in.i_type = X264_TYPE_IDR;
#endif

--- Comment #11 from Andoni Morales <ylatuya at gmail.com> 2011-07-08 10:11:41 UTC ---
Review of attachment 182888:
 --> (https://bugzilla.gnome.org/review?bug=630292&attachment=182888)

::: ext/x264/gstx264enc.c
@@ +1579,3 @@
+      x264_encoder_intra_refresh (encoder->x264enc);
+    else
+      pic_in.i_type = X264_TYPE_IDR;

pic_in.i_type is only set if FORCE_INTRA_API is definied but it should be set
even if it's not defined:
#else
  pic_in.i_type = X264_TYPE_IDR;
#endif

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.