[Bug 654037] gst-ffmpeg enables GPL parts in ffmpeg/libav

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=654037
  GStreamer | gst-ffmpeg | git

--- Comment #3 from Martin Storsjö <martin at martin.st> 2011-07-11 12:26:49 UTC ---
(In reply to comment #2)
> Review of attachment 191353 [details]:
> 
> In addition to the comment about LGPL, this patch should also check dynamically
> how libav (whether included or system-wide) was built in order to modify the
> license field of the plugin details.

Do you mean dynamically as in runtime, via e.g. avcodec_license()? As far as I
can see, the license is compiled in into the binary by GST_PLUGIN_DEFINE() -
how would I update this from e.g. the plugin_init function? (This can't be
decided at compile time, since iirc the ffmpeg headers don't provide info about
how it was configured - unless we just pass an extra define if --enable-gpl was
used.)

> It's a bit late to include this one in the release

No problem, as long as it gets fixed eventually.

> ::: configure.ac
> @@ +207,3 @@
> +AC_ARG_ENABLE(lgpl,
> +              [AC_HELP_STRING([--enable-lgpl], [build a LGPL licensed
> gst-ffmpeg])])
> +AM_CONDITIONAL(LGPL, test "x$enable_lgpl" = "xyes")
> 
> LGPL is too generic of a name. Something like GST_FFMPEG_ENABLE_LGPL would be
> better.

Changed into GST_FFMPEG_ENABLE_LGPL locally, I'll resend it later.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.