[Bug 644233] Set the H.264 level from the caps for encoding

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=644233
  GStreamer | gst-plugins-ugly | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189865|none                        |needs-work
             status|                            |

--- Comment #26 from Sebastian Dröge <slomo at circular-chaos.org> 2011-07-13 08:55:01 UTC ---
Review of attachment 189865:
 --> (https://bugzilla.gnome.org/review?bug=644233&attachment=189865)

Can we get this committed now? I think Thiagos' patch is the correct thing to
do but the _USER should really be renamed to _FROM_PROPERTY (it uses the
property values if the caps would allow both stream formats). And there's a
small bug in his patch

::: ext/x264/gstx264enc.c
@@ +1928,3 @@
     nal_size =
         x264_nal_encode (encoder->buffer + i_size + 4, &i_data, 0, &nal[i]);
+    if (encoder->current_byte_stream)

This is not what you meant, it will be true for _AVC and _BYTESTREAM and not
for _USER. Better add a real comparison with _BYTESTREAM here for correctness
and clarity and also add an assertion that the value is never _USER at this
point.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.